Run Sparkle updater in background to make macOS app work offline. #1071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexCheema
changed the title
JakeHillion
force-pushed
the
alexcheema/macos_app_work_offline
branch
from
93822e1 to
f620fd5
Compare
Member
|
I tested both EXO-latest.dmg and the EXO-1.0.61-alpha.0.dmg and both start fine on a Mac with no Internet connection. Will leave that comment on the issue too, but currently I can't reproduce the issue this is solving. |
Evanev7
previously approved these changes
Jan 6, 2026
Contributor
Author
|
This doesn't seem to fix anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the macOS app requires internet to start, since the sparkle update runs on start in the foreground.
Changes
Run sparkle updater in background.
Why It Works
Sparkle updater no longer runs in the foreground. It now runs in the background so if it fails it will fail gracefully.
Test Plan
Manual Testing
We need to make a new build of the app and ensure it starts without internet.