chore: migrate linter

[tac0turtle]

Overview

Summary by CodeRabbit

• Chores
  • Updated linting workflow to use the latest version of golangci-lint and simplified its configuration.
  • Modernized golangci-lint configuration with improved linter selection, settings, and formatting rules.
  • Removed the integration test job from the automated test workflow.
  • Deleted the Visual Studio Code launch configuration file.
  • Updated the Makefile so the lint task no longer depends on the vet task.

[coderabbitai]

Walkthrough

The updates include several modifications to project configuration and workflow files. The GitHub Actions workflows were simplified: the lint workflow now uses a newer version of the golangci-lint action and removes a step that checked for file changes, while the test workflow removes the integration test job entirely. The golangci-lint configuration file was upgraded to version 2 syntax, with changes to enabled linters, restructuring, and new exclusions and formatters. The Makefile's lint target no longer depends on the vet target. Additionally, the VS Code launch configuration file was deleted.

Changes

File(s)	Change Summary
.github/workflows/lint.yml	Simplified lint workflow: removed diff-check step, upgraded golangci-lint-action to v7.0.0, adjusted run logic.
.github/workflows/test.yml	Removed the integration_test job entirely.
.golangci.yml	Upgraded to version 2 syntax, restructured sections, changed enabled linters, added exclusions and formatters.
Makefile	Removed vet dependency from the lint target; lint now runs directly.
.vscode/launch.json	Deleted VS Code launch configuration for Go debugging.

Possibly related PRs

• chore: fix linter issues #13: Related update to linting workflows and configuration, with differences in linters and config structure.

Suggested reviewers

• gupadhyaya
• MSevey

Poem

In the warren, code hops anew,
Linters upgraded, old jobs bid adieu.
The Makefile's lighter, the config refined,
With exclusions and formatters neatly aligned.
No more integration tests for now—
The rabbit bows, takes a linting vow!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ee2a17 and a89e9a4.

📒 Files selected for processing (1)

• .golangci.yml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• .golangci.yml

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Pull Request Overview

This PR migrates the linter configuration to a newer setup and updates the associated GitHub workflow.

• Updates .golangci.yml with a new version, adjusted linter enable lists, and added exclusions and formatters.
• Updates the GitHub workflow to use an updated golangci-lint-action version.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
.golangci.yml	Migrated configuration for linters with updated rules and exclusions.
.github/workflows/lint.yml	Updated linter action version from v3.7.0 to v7.0.0.

Files not reviewed (1)

• Makefile: Language not supported

[coderabbitai]

Actionable comments posted: 0

🔭 Outside diff range comments (1)

.github/workflows/lint.yml (1)

16-23: 🛠️ Refactor suggestion

⚠️ Potential issue

Fix the conditional guard for the lint step.

The step still uses if: env.GIT_DIFF, but you removed the action that sets GIT_DIFF. As a result, the golangci-lint-action job will never run. Either:

• Remove the if: env.GIT_DIFF line, or
• Reintroduce a diff-generation step before running the linter.

♻️ Duplicate comments (1)

.golangci.yml (1)

6-10: Remove duplicated gosec linter.

The gosec linter appears twice in the enable list (lines 6 and 10), resulting in redundant scans. Please remove one of the entries.

🧹 Nitpick comments (1)

Makefile (1)

40-43: Consider reintroducing go vet.

By removing the vet prerequisite from the lint target, foundational checks via go vet are skipped. You may want to:

lint:
	@echo "--> Running go vet"
	@go vet $(pkgs)
	@echo "--> Running golangci-lint"
	@golangci-lint run
	...

or document explicitly that vet is only run under test.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fcf087c and 8ee2a17.

📒 Files selected for processing (5)

• .github/workflows/lint.yml (1 hunks)
• .github/workflows/test.yml (0 hunks)
• .golangci.yml (1 hunks)
• .vscode/launch.json (0 hunks)
• Makefile (1 hunks)

💤 Files with no reviewable changes (2)

• .github/workflows/test.yml
• .vscode/launch.json

🔇 Additional comments (4)

.golangci.yml (4)

1-3: Confirm v2 syntax requirements.

Upgrading to version: "2" is correct for golangci-lint v7, but by removing the global timeout under run, the default (1m) may be too short for larger codebases. Consider explicitly adding:

run:
  timeout: 5m
  modules-download-mode: readonly

to avoid unexpected timeouts.

---

9-13: Approve additional static-analysis linters.

Adding errorlint, unconvert, and staticcheck strengthens error-handling checks and removes unnecessary conversions. This modernization aligns with current Go best practices.

---

14-24: Verify the settings section and exclusions syntax.

You renamed linters-settings to a generic settings block and introduced an exclusions subsection. Ensure that:

• golangci-lint v2 accepts settings (not linters-settings) as the root key.
• exclusions is the correct v2 field (versus issues.exclude-rules).
  If not, revert to the documented v2 schema to prevent silent config omissions.

---

30-43: Approve formatters configuration.

Enabling gofmt and goimports as formatters with local-prefixes: github.com/rollkit is a solid choice. The exclusions for generated code and third_party, builtin, and examples directories match the project structure.

[tac0turtle]

closing as we will archive this repo