feat: export latency percentiles #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
commented
Oct 23, 2025
Comment on lines
47
to
48
| type=semver,pattern=v{{version}} | ||
| type=semver,pattern=v{{major}}.{{minor}} |
Collaborator
Author
There was a problem hiding this comment.
unrelated change but I think the tag should have the prefix v to match the git tag directly.
chatton
commented
Oct 23, 2025
| } | ||
|
|
||
| // GetBlockTimestamp retrieves the timestamp of a celestia da block at the given height | ||
| func (c *Client) GetBlockTimestamp(ctx context.Context, daHeight uint64) (time.Time, error) { |
Collaborator
Author
There was a problem hiding this comment.
this functionality isn't directly available on the embedded DA client
Collaborator
can be exploited on very useful visualizations |
auricom
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following is a sample of what was exposed when running locally
The values are not very good right now, but there is an issue with DA submission ATM which will hopefully help once fixed, and there may be something else to investigate on the ev-node side.
closes #1