You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @xamelon, good idea. Here are things that need to be done before it is merged:
Create activity indicator when image starts downloading, and not on init, since download does not necessarily needs to start after the image view is created.
Handle case when one moa image view displays multiple images in succession: one after another. In each case, indicator should be created on download and removed when it finishes/fails.
Only create activity indicator object when it is needed. Don't create it by default, since most current users don't need it, or don't expect it to be there. This can be done by adding a setting moa.showActivityIndicator = true, which is false by default.
Position activity indicator using auto layout constraints instead of frame coordinates. This will ensure the indicator remains in place when image view changes size (on phone orientation change, for example).
Add unit test.
Add documentation to readme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added UIActivityIndicator when image is downloading