Skip to content

fix(tests): EOF - Rename RETURNCONTRACT to RETURNCODE #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marioevz merged 1 commit into from
Mar 17, 2025
Merged

fix(tests): EOF - Rename RETURNCONTRACT to RETURNCODE #1284

marioevz merged 1 commit into from
Mar 17, 2025

Conversation

@pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Mar 6, 2025 •
edited
Loading

🗒️ Description

As title, aligns with ipsilon/eof#182

🔗 Related Issues

NA

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

This was referenced Mar 6, 2025
Merged
Closed
@pdobacz pdobacz marked this pull request as ready for review March 11, 2025 13:45
@pdobacz pdobacz requested review from chfast and marioevz March 11, 2025 13:46
@pdobacz pdobacz added scope:tests Scope: Changes EL client test cases in `./tests` scope:fw Scope: Framework (evm|tools|forks|pytest) type:refactor Type: Refactor labels Mar 12, 2025
winsvega
winsvega reviewed Mar 17, 2025
View reviewed changes
winsvega
winsvega approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove returncontract string from white list then?

marioevz
marioevz approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't manually review every file, rather I refilled all tests and it seems to be working.

@marioevz marioevz merged commit aaa363b into ethereum:main Mar 17, 2025
11 checks passed
@marioevz marioevz deleted the returncode branch March 17, 2025 19:11
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
@pdobacz @felix314159
fix(tests): EOF - Rename RETURNCONTRACT to RETURNCODE (ethereum#1284)
39eb2f6
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
@pdobacz
fix(tests): EOF - Rename RETURNCONTRACT to RETURNCODE (ethereum#1284)
df622b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marioevz marioevz marioevz approved these changes

@chfast chfast Awaiting requested review from chfast

+1 more reviewer

@winsvega winsvega winsvega approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

scope:fw Scope: Framework (evm|tools|forks|pytest) scope:tests Scope: Changes EL client test cases in `./tests` type:refactor Type: Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pdobacz @winsvega @marioevz