-
Notifications
You must be signed in to change notification settings - Fork 7
fine-grade probing per cluster and service #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fine-grade probing per cluster and service #156
Conversation
jpdorsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work!
theely
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good.
Just a minor comment on how to organize the settings structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, nice work!!
LGTM
p.s. before merging please fix the issue reported by the linter
Implemented fine grade probing for service and cluster
Configuration has changed based on the following structure.
Interval shall be the same for al the tests, managed in the same probe cycle.