Skip to content

Conversation

@BioRevolution
Copy link
Contributor

@BioRevolution BioRevolution commented May 20, 2025

Dear Admin,

I would like to request regrouping two waveshare products (#1 and #2) and add two more products (#3 and #4). What is the regrouping procedure? I merged these requested changes into the fragmented unallocated PIDs in the list.

  1. Request change to Waveshare ESP32-S3-Touch-AMOLED-2.41: Product link: https://www.waveshare.com/product/esp32-s3-touch-amoled-2.41.htm This device only has a PID for Arduino at 0x8242. No PIDs are reserved for CircuitPython/MicroPython and UF2 Bootloader. Please consider revising to add PIDs for CircuitPython/MicroPython and UF2 Bootloader in three sequential PIDS like this: -- Arduino
    -- CircuitPython/MicroPython
    -- UF2 Bootloader.

  2. Request change to Waveshare ESP32-S3-Touch-AMOLED-1.43: Product link: https://www.waveshare.com/product/esp32-s3-touch-amoled-1.43.htm?sku=30203 This device only has a PID for Arduino at 0x824A. No PIDs are reserved for CircuitPython/MicroPython and UF2 Bootloader. Please consider revising to add PIDs for CircuitPython/MicroPython and UF2 Bootloader in three sequential PIDS like this: -- Arduino
    -- CircuitPython/MicroPython
    -- UF2 Bootloader.

  3. Add Waveshare ESP32-S3-Touch-LCD-1.3: Product link: https://www.waveshare.com/product/esp32-s3-lcd-1.3.htm?sku=29962 Please assign three sequential PIDs for:
    -- Arduino
    -- CircuitPython/MicroPython
    -- UF2 Bootloader.

  4. Add Waveshare ESP32-S3-Touch-LCD-3.5: Product link: https://www.waveshare.com/product/esp32-s3-touch-lcd-3.5.htm?sku=30934 Please assign three sequential PIDs for:
    -- Arduino
    -- CircuitPython/MicroPython
    -- UF2 Bootloader.

Thank you very much!

1. Request change to Waveshare ESP32-S3-Touch-AMOLED-2.41:
Product link: https://www.waveshare.com/product/esp32-s3-touch-amoled-2.41.htm
This device only has a PID for Arduino at 0x8242.  No PIDs are reserved for CircuitPython/MicroPython and UF2 Bootloader.  Please consider revising to add PIDs for CircuitPython/MicroPython and UF2 Bootloader in three sequential PIDS like this: 
-- Arduino
-- CircuitPython/MicroPython
-- UF2 Bootloader.


2. Request change to Waveshare ESP32-S3-Touch-AMOLED-1.43:
Product link: https://www.waveshare.com/product/esp32-s3-touch-amoled-1.43.htm?sku=30203
This device only has a PID for Arduino at 0x824A.  No PIDs are reserved for CircuitPython/MicroPython and UF2 Bootloader.  Please consider revising to add PIDs for CircuitPython/MicroPython and UF2 Bootloader in three sequential PIDS like this: 
-- Arduino
-- CircuitPython/MicroPython
-- UF2 Bootloader.


3. Add Waveshare ESP32-S3-Touch-LCD-1.3:
Product link: https://www.waveshare.com/product/esp32-s3-lcd-1.3.htm?sku=29962
Please assign three sequential PIDs for: 
-- Arduino
-- CircuitPython/MicroPython
-- UF2 Bootloader.


4. Add Waveshare ESP32-S3-Touch-LCD-3.5:
Product link: https://www.waveshare.com/product/esp32-s3-touch-lcd-3.5.htm?sku=30934
Please assign three sequential PIDs for: 
-- Arduino
-- CircuitPython/MicroPython
-- UF2 Bootloader.

Thank you very much!
@Spritetm
Copy link
Member

Hiya! First of all, I don't like to change any PIDs when they're already on the list (and have been for a while), people might use them and I don't think there's real value in the ordering of the numbers anyway. Secondly, normally we'd like you to allocate PIDs at the end of the list, but if you feel like using the unallocated gaps for new pids, that is fine.

@BioRevolution
Copy link
Contributor Author

Hi Spritetm! Thanks for explaining the policy. I revised the pull request :)

@Spritetm
Copy link
Member

Looks good now, I'll merge, thanks!

@Spritetm Spritetm merged commit 6fecb2d into espressif:main May 22, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants