-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Add webhook after successful action #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello kumekay, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
|
@tomassebestik Don't you mind this approach? |
@kumekay Added functionality and the way it’s implemented look good to me (the long-term plan is to rewrite this action from scratch, and this looks clear and easily portable to the future code version). It would be helpful tho, to describe this new webhook feature a bit in the project docs (README). What that is, why repo admins should set that and maybe with an example. WDYT? |
91e444a to
7601b87
Compare
a386735 to
7cf3d3f
Compare
7cf3d3f to
e37192a
Compare
cd074e8 to
bd83169
Compare
bd83169 to
c67cf8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds webhook functionality to send notifications after successful JIRA ticket synchronization operations. The implementation allows for optional webhook notifications by setting the WEBHOOK_URL environment variable.
Key changes:
- Creates a new webhook module with comprehensive payload structure
- Integrates webhook calls into all sync operations (manual, cron, and event-driven)
- Adds comprehensive test coverage for webhook functionality
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
sync_jira_actions/webhook.py |
New webhook module implementing notification sending with proper error handling |
tests/test_webhook.py |
Complete test suite covering success, failure, and edge cases for webhook functionality |
sync_jira_actions/sync_to_jira.py |
Main integration point adding webhook calls after successful actions |
sync_jira_actions/sync_issue.py |
Modified issue handlers to return JIRA issue objects for webhook payload |
sync_jira_actions/sync_pr.py |
Added callback support for PR synchronization operations |
action.yml |
Added WEBHOOK_URL environment variable configuration |
README.md |
Documentation for webhook configuration and payload structure |
| Other files | Version bump, dependency updates, and configuration changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description
Add WEBHOOK_URL (optional) for an URL which will be called after every successful JIRA ticket update
Related
Testing
Successful test pipeline:
https://github.com/espressif/test-project-bot/actions/runs/17070187014/job/48396799666#step:3:303
Receieved Webhook can be found in windmill
Checklist
Before submitting a Pull Request, please ensure the following: