EIM-512 switched the output from the run command to streamig

[Hahihula]

this should improve the experience from the run command. It will no longer wait for the command to finish but stream the output directly.

[gemini-code-assist]

Summary of Changes

Hello @Hahihula, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user experience for the run command by transitioning from buffered command output to real-time streaming. This change prevents the application from waiting for command completion before displaying any output, making long-running operations feel more responsive and interactive. The underlying command execution logic has been refactored to support this streaming behavior, ensuring that command failures are immediately reflected by the application's exit status.

Highlights

• Streaming Command Output: Implemented a new method for executing shell commands that streams their output directly to the parent process's standard I/O, improving the user experience for long-running commands.
• Refactored Command Execution: The core run_command_in_context function was updated to utilize the new streaming execution method and now returns an ExitStatus instead of the full Output.
• CLI Output Handling: The CLI's run_cli function was adjusted to reflect the change in command execution, now directly exiting the process if the executed command fails, rather than printing its stdout/stderr.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src-tauri/src/cli/mod.rs
  • Modified the run_cli function to process ExitStatus instead of Output from run_command_in_context.
  • Removed explicit printing of command stdout and stderr.
  • Implemented direct process exit if the executed command returns a non-success status.
• src-tauri/src/lib/command_executor.rs
  • Introduced run_script_from_string_streaming to the CommandExecutor trait.
  • Implemented run_script_from_string_streaming in DefaultExecutor to execute scripts with inherited standard I/O streams.
• src-tauri/src/lib/version_manager.rs
  • Imported std::process::ExitStatus.
  • Modified the run_command_in_context function signature to return anyhow::Result<ExitStatus>.
  • Updated run_command_in_context to use the new run_script_from_string_streaming method for command execution.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request switches the run command to stream output, which is a great improvement for user experience.

I've found two main issues:

1. The use of std::process::exit in src-tauri/src/cli/mod.rs should be replaced with proper error propagation to allow for graceful shutdown and cleanup.
2. The WindowsExecutor is missing an implementation for the new run_script_from_string_streaming method, which will cause compilation to fail on Windows.

I've left detailed comments with suggestions on how to address these.

Also, there's a small typo in the pull request title: 'streamig' should be 'streaming'.

[mfialaf]

I didn’t review the code itself, but I verified that the functionality - works as expected. Thank you very much for the fast update.

I tested it with the Cursor MCP agent as well as Claude, using the MCP command eim run idf.py mcp-server. Additionally, I ran eim run idf.py monitor and eim run idf.py menuconfig, and both worked as expected.

Note: Tested only on MacOS

[Fabricio-ESP]

Thanks Petr for the update.
Confirmed working as expected on MacOS.

Issue on Windows. Using powershell there is no return printed on terminal, neither streamed to terminal, or after the job is completed.