-
Notifications
You must be signed in to change notification settings - Fork 3
Eim 281 broadening python support in offline installer #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eim 281 broadening python support in offline installer #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Hahihula, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the offline installer's Python support by enabling it to work with a wider range of Python versions (3.10-3.13) on POSIX operating systems. It achieves this by implementing dynamic detection of the Python version during installation and managing version-specific Python wheel packages, ensuring greater compatibility and future-proofing for Python environments.
Highlights
- Broadened Python Support for POSIX: The offline installer now supports Python versions 3.10, 3.11, 3.12, and 3.13 on POSIX systems. Windows continues to rely on Python 3.11.
- Dynamic Python Version Detection: New utility functions have been introduced to detect the Python version within a virtual environment and locate corresponding version-specific wheel directories (e.g.,
wheels_py311). - Multi-Version Wheel Downloading: The offline installer builder can now download Python wheels for multiple specified Python versions, creating separate wheel archives for each, which improves flexibility and compatibility.
- New CLI Argument for Wheel Versions: A new command-line argument
--wheel-python-versionshas been added to the offline installer builder, allowing users to explicitly define which Python versions to download wheels for.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enhances the offline installer by adding support for multiple Python versions on POSIX systems, which is a great improvement for flexibility. The changes include new logic to detect the Python version and locate the corresponding wheel directory. The offline installer builder is also refactored to download wheels for different Python versions.
I've found a couple of areas for improvement: one is a minor code redundancy, and the other is related to robust path handling to prevent potential panics with non-UTF-8 paths. My detailed comments are below.
on windows we still rely on the python 3.11 as we are installing it ourselves
on POSIX we should now support python versions "3.10", "3.11", "3.12", "3.13"