Skip to content

Conversation

@Fabricio-ESP
Copy link
Collaborator

Description

This PR add the automated tests for IDF offline installation, using the archives build withing the run.
The workflow is set to run the test when the offline archives are built and also allow manual execution pointing to artifacts from another workflow execution (if only testing is desired).

The same approach is applied to the other test workflows to allow manual execution based on artifacts from another run, this allows quicker feedback when only changing the test workflow by using previously built artifacts.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Fabricio-ESP, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces automated testing for the IDF (IoT Development Framework) offline installation process. It establishes a new test type specifically for offline installations, leveraging pre-built archives. The changes also enhance the overall testing workflow by enabling manual execution of tests using artifacts from previous runs, which significantly speeds up feedback cycles for test-related modifications.

Highlights

  • New Offline Test Type: A new test type, "offline", has been introduced within the CLIRunner to specifically validate the offline installation process of IDF.
  • Configurable Offline Archive Path: A new configuration option, pathToOfflineArchive, has been added to specify the location of the offline installation archive, supporting both environment variables and a default path.
  • Dedicated Offline Test Suite: A dedicated test suite file, CLI-offline.json, has been created to define and orchestrate the new automated tests for the offline installation scenario.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces automated tests for offline installation of the IDF, which is a great addition. The changes involve adding a new 'offline' test type, configuring the path to the offline archive, and defining a new test suite. My review focuses on improving the robustness and maintainability of these new tests. I've identified a potential bug related to file paths with spaces, a hardcoded value that could make tests brittle, a minor code simplification, and a typo fix.

Copy link
Collaborator

@Hahihula Hahihula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As first step to make the debugging easier. Thanks for the fix with run id/number.

@Fabricio-ESP Fabricio-ESP force-pushed the EIM-282-test-offline-installer branch from 4983137 to 1fc31c0 Compare August 26, 2025 15:24
@Fabricio-ESP Fabricio-ESP force-pushed the EIM-282-test-offline-installer branch from 1fc31c0 to c2248c6 Compare August 26, 2025 18:01
@Fabricio-ESP Fabricio-ESP merged commit ab1fe80 into master Aug 26, 2025
37 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants