feat(esp_sysview): adapt esp_trace usj transport type#679
Open
erhankur wants to merge 1 commit intoespressif:masterfrom
Open
feat(esp_sysview): adapt esp_trace usj transport type#679erhankur wants to merge 1 commit intoespressif:masterfrom
erhankur wants to merge 1 commit intoespressif:masterfrom
Conversation
erhankur
force-pushed
the
adapt_sysview_to_usb_serial_jtag
branch
from
378c914 to
1b8b08a
Compare
erhankur
force-pushed
the
adapt_sysview_to_usb_serial_jtag
branch
from
1b8b08a to
7095f43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new USB Serial JTAG transport type has been introduced in the esp_trace component. Its write behavior and multi core event routing are identical to UART, so instead of adding another explicit check (== ESP_TRACE_LINK_USJ), the conditions are inverted to != ESP_TRACE_LINK_DEBUG_PROBE. This keeps the debug probe path explicit and makes the common path the default for all other transports, including any added in the future.