Draft: Fix/pre encrypted ota test partial download#671
Open
AdityaHPatwardhan wants to merge 6 commits intoespressif:masterfrom
Open
Draft: Fix/pre encrypted ota test partial download#671AdityaHPatwardhan wants to merge 6 commits intoespressif:masterfrom
AdityaHPatwardhan wants to merge 6 commits intoespressif:masterfrom
Conversation
|
|
AdityaHPatwardhan
changed the title
AdityaHPatwardhan
force-pushed
the
fix/pre_encrypted_ota_test_partial_download
branch
from
afdbfe3 to
627501f
Compare
AdityaHPatwardhan
requested review from
hfudev
and removed request for
hfudev
The config fixture is provided by idf-ci and is needed when running pytest, not during the build phase. Moved idf-ci installation from the build job to run-target and run-target-linux jobs where pytest actually executes.
Add a local config fixture to avoid dependency on idf-ci package during pytest collection. This allows tests to be collected on environments where idf-ci cannot be installed (e.g., Python 3.14).
Removed unused imports FlashFile and IdfSerial which require esptool. This allows pytest to collect tests on Linux where esptool is not installed.
AdityaHPatwardhan
force-pushed
the
fix/pre_encrypted_ota_test_partial_download
branch
2 times, most recently
from
1241784 to
53aa110
Compare
…test.py The config fixture is provided by idf-ci, so it needs to be installed in both run-target and run-target-linux jobs. The local conftest.py was redundant and could cause conflicts with the idf-ci plugin.
…atibility The run-target-linux job uses Python 3.14 which is not supported by idf-ci (only supports Python 3.7-3.13). Without idf-ci, the 'config' fixture used by the parametrized test is not available, causing pytest collection to fail. This adds a local conftest.py with a 'config' fixture that allows pytest collection to succeed on environments without idf-ci. When idf-ci is available (like in run-target job with Python 3.11), its IdfPytestPlugin provides the same fixture with additional features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
urlfield definedChange description
Please describe your change here