network_provisioning: Fix prov-ctrl reset handler to return success #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen already in provisioning mode If firmware has already called network_prov_mgr_reset_wifi_sm_state_on_failure() or network_prov_mgr_reset_thread_sm_state_on_failure(), the device state is already reset to provisioning mode. The prov-ctrl handler now returns success in this case instead of an invalid state error, allowing phone apps to successfully reset even if firmware has already performed the reset operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when already in provisioning mode
Checklist
urlfield definedChange description
If firmware has already called network_prov_mgr_reset_wifi_sm_state_on_failure() or network_prov_mgr_reset_thread_sm_state_on_failure(), the device state is already reset to provisioning mode. The prov-ctrl handler now returns success in this case instead of an invalid state error, allowing phone apps to successfully reset even if the firmware has already performed the reset operation. Without this change, the phone apps get an error unnecessarily since they have no way to know if the firmware has called the reset.