fix(led_strip): use IRAM_ATTR for RMT encoder functions (IEC-451) #637
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
changed the title
suda-morris
approved these changes
Dec 4, 2025
Collaborator
suda-morris
left a comment
suda-morris
left a comment
There was a problem hiding this comment.
Thanks for the fix! LGTM.
suda-morris
force-pushed
the
fix-led-strip-iram-attr
branch
from
198d4ac to
664db82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
urlfield definedChange description
Closes #636
According to the documentation, the RMT encoder functions should have
IRAM_ATTRwhen RMT ISR is placed in IRAM.RMT_ENCODER_FUNC_ATTRhas been introduced in ESP-IDF v5.5, so for earlier versions it is defined locally.