-
Notifications
You must be signed in to change notification settings - Fork 121
fix(coap): Update to libcoap v4.3.5a (IEC-430) #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for raising this PR. I see more CVEs in the vulnerability scan for current coap version: ...snip... CVE-2025-65493 Could you please check these CVEs once? Any plans to release a new bugfix version update to coap library? |
|
@mahavirj Thanks for picking up on these CVEs which have been raised in the last few days. I was not informed that they were being raised, but they are fixed in the patch code I had submitted. As there is an issue in GnuTLS (not relevant to Espressif) which is not fixed in libcoap branch release-4.3.5-patches, I will get this included and update this PR with the updated libcoap code. There is an additional MbedTLS fix which I will include as well. Is there something I need to do to fix the 4 build failures? It does look like you need to add to the GitHub workflow but this is not the issue with the builds. |
|
Is this the build issue ? |
Added workaround for this in #628. Please rebase your PR. |
| override_path: ../../../ | ||
| protocol_examples_common: | ||
| path: ${IDF_PATH}/examples/common_components/protocol_examples_common | ||
| espressif/ethernet_init: '*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be required, protocol_examples_common should internally pull in this dependency. Are you getting some build error without this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting a local build error complaining that espressif__ethernet_init was not available. So I did a idf.py add-dependency espressif/ethernet_init which updated the idf_component.yml file (did it for both coap_client and coap_server) with their current changes.
However, reverting back to master I no longer get the issue, but it may be that another file was touched when doing idf.py add-dependency espressif/ethernet_init.
At some point I did python /home/jon/esp/esp-idf/tools/idf_tools.py uninstall as recommended to clean up some clutter, but this was before doing the idf.py add-dependency espressif/ethernet_init.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing espressif/ethernet_init: '*' makes no difference, so I will remove them now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did bump version in coap/idf_component.yml later on - which could have been after I did idf.py add-dependency espressif/ethernet_init.
Fixes some critical issues.
Checklist
urlfield definedChange description
Fixes some critical issues.