feat(sh2lib): distinct recv and send funcs (IEC-429) #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryghtlabs-richard
force-pushed
the
feat/sh2lib/splitSendRecv
branch
from
fcfa72e to
035fafa
Compare
bryghtlabs-richard
changed the title
bryghtlabs-richard
force-pushed
the
feat/sh2lib/splitSendRecv
branch
from
035fafa to
58afc5b
Compare
bryghtlabs-richard
changed the title
github-actions
bot
changed the title
mahavirj
reviewed
Nov 25, 2025
sh2lib_execute() processes send, then recv. This is fine for a general purpose connection, but can lead to code like: loop: 1) sh2lib_execute() 2) based on handler called in (1), sh2lib_do_get/post() 3) do other system task ^^This means that any requests queued in (2) cannot be sent until the next sh2lib_execute(). Instead, this commit splits sh2lib_execute() into distinct _send() and _recv() phases, so client use this pattern, which reduces latency between request generation in (2) and request sending in(3): loop: 1) sh2lib_execute_recv() 2) based on handler called in (1), sh2lib_do_get/post() 3) sh2lib_execute_send() 4) do other system task
When `sh2lib_execute*(NULL);` occurs, log an error instead of crashing. See: espressif#623 (comment)
bryghtlabs-richard
force-pushed
the
feat/sh2lib/splitSendRecv
branch
from
58afc5b to
2e3f5e5
Compare
mahavirj
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
urlfield definedChange description
Enable processing received HTTP client traffic before sending HTTP client traffic. This can reduce latency in a few cases: