Skip to content

Conversation

@adokitkat
Copy link
Collaborator

@adokitkat adokitkat commented Nov 19, 2025

Checklist

  • Optional: Component contains unit tests
  • CI passing

Description

Added BDL support for esp_ext_part_tables component.

// Reads the partition table from a block device and parses & loads it to `esp_ext_part_list_t` struct
esp_err_t esp_ext_part_list_bdl_read(esp_blockdev_handle_t handle, esp_ext_part_list_t *part_list, esp_ext_part_signature_type_t type, void *extra_args);

// Generates the partition table from `esp_ext_part_list_t` struct and writes it to a block device
esp_err_t esp_ext_part_list_bdl_write(esp_blockdev_handle_t handle, esp_ext_part_list_t *part_list, esp_ext_part_signature_type_t type, void *extra_args);

With these functions which can use a BDL interface, this component can access other storage related components (if they also have a BDL API), e.g. read MBR directly and parse it to esp_ext_part_list.

@adokitkat adokitkat self-assigned this Nov 19, 2025
@adokitkat adokitkat changed the title feat(esp_ext_part_tables): Add support for BDL feat(esp_ext_part_tables): Add support for BDL ([IEC-422](https://jira.espressif.com:8443/browse/IEC-422)) Nov 19, 2025
@adokitkat adokitkat changed the title feat(esp_ext_part_tables): Add support for BDL ([IEC-422](https://jira.espressif.com:8443/browse/IEC-422)) feat(esp_ext_part_tables): Add support for BDL (IEC-422) Nov 19, 2025
@adokitkat adokitkat force-pushed the feat/add_support_for_bdl branch 2 times, most recently from 19b9241 to fe45f6d Compare November 20, 2025 00:19
@adokitkat adokitkat force-pushed the feat/add_support_for_bdl branch from 314ca4d to 308c238 Compare November 20, 2025 13:40
@pacucha42
Copy link
Collaborator

Generally LGTM, left only few minor comments. Please:

  • finish your checklist
  • remove Draft once ready to merge

Thanks

@adokitkat adokitkat force-pushed the feat/add_support_for_bdl branch from 308c238 to 123d3d7 Compare November 30, 2025 00:13
@adokitkat adokitkat marked this pull request as ready for review November 30, 2025 00:14
@pacucha42
Copy link
Collaborator

Also, please slightly extend the description of this PR - a short explanation why we need these API functions would help. Thank you

@adokitkat adokitkat force-pushed the feat/add_support_for_bdl branch from 123d3d7 to a30f859 Compare November 30, 2025 15:11
@pacucha42
Copy link
Collaborator

Well, thanks for update - I thought the names would be like esp_ext_part_list_write_bdl, not esp_ext_part_list_bdl_write 🙂 (see my note '.. at the end'). Whatever, it's good enough now, let's merge. Thanks for your efforts

Copy link
Collaborator

@pacucha42 pacucha42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The only point - before merging, please, extend the PR's description as requested before

@pacucha42 pacucha42 merged commit 34c58d6 into espressif:master Nov 30, 2025
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants