Add support of user_data in read_cb (Fixes #604) (IEC-413) #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
changed the title
Collaborator
|
@erwinschrodinger1 Could you please Bump the the component version and update the Changelog.md. You can take reference from this PR |
Collaborator
|
@erwinschrodinger1 This PR looks good to me, just few comments. Fix those comments and I will take this PR internally. Thanks. NOTE: While committing please use pre-commit hook. |
Added in reference to write callback. Is backward compatible. Tested with file read using FileIO in esp32s3.
erwinschrodinger1
force-pushed
the
master
branch
from
0c8153f to
8746e62
Compare
hrushikesh430
approved these changes
Nov 25, 2025
Co-authored-by: hrushikesh430 <[email protected]>
Collaborator
|
@erwinschrodinger1 Could you please fix the pre-commit errors. Please use the |
Contributor
Author
|
@hrushikesh430 Sorry for the inconveniences caused. I have now run the pre-commit in all the files. Can you please verify it once? |
espressif-bot
added
Status: Done
Resolution: Done
and removed
Status: In Progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
urlfield definedChange description
Add support of user_data in read_cb
Added in reference to write callback.
Is backward compatible.
Tested with file read using FileIO in esp32s3.