Improve 'subscribe_command` callbacks (CON-1960)#1690
Open
tomasmcguinness wants to merge 2 commits intoespressif:mainfrom
Open
Improve 'subscribe_command` callbacks (CON-1960)#1690tomasmcguinness wants to merge 2 commits intoespressif:mainfrom
tomasmcguinness wants to merge 2 commits intoespressif:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes two main changes to the
subscribe_commandFirst, a new
subscription_established_cb_thas been added along with a new parameterestablished_cb.Second, the existing
subscribe_done_cb_thas been renamed tosubscription_terminated_cbto better reflect what it means.The new
established_cballows a controller to know when thesubscribe_commandhas been sent and processed.Renaming
done_cb->terminated_cbmakes the callback's use much clearer. Done usually means success, but in this case it refers to subscriptions being terminated.The existing constructors remain so no breaking changes should be introduced.
Testing
I have tested this in my controller:
Session establishment is reported
Termination is reported
Failure to subscribe is reported:
Checklist
Before submitting a Pull Request, please ensure the following: