components/esp-matter: added features support to power source device … (CON-1498)#1230
Draft
bnadim wants to merge 2 commits intoespressif:mainfrom
Draft
components/esp-matter: added features support to power source device … (CON-1498)#1230bnadim wants to merge 2 commits intoespressif:mainfrom
bnadim wants to merge 2 commits intoespressif:mainfrom
Conversation
|
|
github-actions
bot
changed the title
shubhamdp
reviewed
Jan 7, 2025
| } | ||
|
|
||
| cluster_t *cluster = power_source::create(endpoint, &(config->power_source), CLUSTER_FLAG_SERVER, ESP_MATTER_NONE_FEATURE_ID); | ||
| cluster_t *cluster = power_source::create(endpoint, &(config->power_source), CLUSTER_FLAG_SERVER, config->descriptor.features); |
Contributor
There was a problem hiding this comment.
It should have been the feature flags of the Power Source cluster and not of the Descriptor cluster.
Ideally, power_source::config_t should have the features member variable, and that should be set when creating the device type, then that value has to be used in here instead of the descriptor cluster's.
We are in the process of adding the feature_flags member variable to every cluster's config_t and will be available soon, and then that can be populated when creating the device type.
I'd suggest please wait till then.
Author
There was a problem hiding this comment.
Hey thank you for your feedback.
I understand. So i will wait until features member is added and update my pr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on matter spec 1.3, power source endpoint should support features Wired, Battery, Rechargeable, Replaceable.
This is supported in the cluster creation and in endpoint config through descriptors, but on endpoint creation, descriptor feature are not passed to cluster at creation resulting in ignoring feature attributes.
This pr fix this by passing the features to cluster creation which was an omission.
Although it doesn't introduce breaking changes strictly speaking, if a user did provided feature in descriptor and did not update attributes, it may introduce a change.
Related
Testing
Tested on a matter setup with an Apple homepod device and Apple home app showing low battery level.
Checklist
Before submitting a Pull Request, please ensure the following: