-
Notifications
You must be signed in to change notification settings - Fork 937
fix: AHT20 - remove incorrect check for CRC bit (AEGHB-1314) #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello SvenRH, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
|
@SvenRH This may be because the component is developed for both AHT20 and AHT30 (as declared in https://github.com/espressif/esp-iot-solution/tree/master/components/sensors/humiture/aht20#component-aht20), While Espressif CI only tests with the AHT30, the issue is not exposed
|
|
|
||
| #define AT581X_STATUS_CMP_INT (2) /* 1 --Out threshold range; 0 --In threshold range */ | ||
| #define AT581X_STATUS_Calibration_Enable (3) /* 1 --Calibration enable; 0 --Calibration disable */ | ||
| #define AT581X_STATUS_CRC_FLAG (4) /* 1 --CRC ok; 0 --CRC failed */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest keeping this MARCO defined, but specify the AHT30 in the comment
leeebo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SvenRH LGTM! nitpick, please update the component's CHANGELOG.md also

Description
There was a incorrect check for a CRC bit in the response from the sensor.
This bit is NOT defined in the datasheet and some versions of the chip don't set this bit.
Related
Datasheet
Testing
As it's just the removable of a wrong check, I just tested it in my test project,
Checklist
Before submitting a Pull Request, please ensure the following: