Skip to content

Conversation

@nurdism
Copy link

@nurdism nurdism commented Aug 7, 2025

Description

Attempting to use the existing esp_lcd_touch_spd2010 does not function using lates i2c drivers. So I took some time to rewrite/update the driver.

Testing

Tested on the ESP32 S3 Touch LCD 1.46

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass. (not sure how to do this)
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas. (No Datasheet, had to rely on demo code provided by waveshare, it's not well documented)
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Aug 7, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello nurdism, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against fa7d73f

@github-actions github-actions bot changed the title refactor(esp_lcd_touch_spd2010): Refactor the spd2010 touch driver refactor(esp_lcd_touch_spd2010): Refactor the spd2010 touch driver (AEGHB-1171) Aug 7, 2025
@Horion0415
Copy link
Contributor

Sorry I only noticed this PR now. Thank you very much for the improvements to spd2010, but there are a few points I’d like to discuss:

  1. I noticed that tp->data.points is no longer cleared. This may cause the same set of coordinates to be read repeatedly, which breaks the “consume-once” semantics of touch events. If the upper layer relies on the behavior that data is cleared after a single read, this change could result in “stuck” touch points.

  2. I also noticed that in the I2C read path, lcd_cmd is passed as -1 to esp_lcd_panel_io_rx_param, and lcd_cmd_bits is changed to 8. I’d like to confirm whether the SPD2010 actually allows a read operation after a STOP condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants