esp_tinyuf2: fix nvs hidden key (AEGHB-961)#462
esp_tinyuf2: fix nvs hidden key (AEGHB-961)#462wormyrocks wants to merge 6 commits intoespressif:masterfrom
Conversation
|
|
👋 Hello wormyrocks, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
|
@wormyrocks LGTM! |
| * @return | ||
| * - ESP_OK: Operation was successful. | ||
| */ | ||
| esp_err_t esp_tinyuf2_set_all_key_hidden(bool if_hidden) |
There was a problem hiding this comment.
@wormyrocks, is there any difference? Whether there is a formal parameter or not, makes no difference to the function itself.
There was a problem hiding this comment.
On my machine it won't compile without this change - something to do with the compiler settings in tinyuf2.
Outside of the include guards, all the other declarations in that file follow the same style.
|
@wormyrocks thanks for your contribution, It looks great to me! |
|
Hi @wormyrocks, this PR is blocked because the CLA has not been signed. Please sign it when you're free, and we will merge it then. #462 (comment) |
Description
Allows the use of hidden NVS keys in the uf2 config.ini.
Also fixes an error where NVS entries intended to be hidden would be shown, and entries intended to be shown would be hidden.