Skip to content

Conversation

@acouvreur
Copy link

@acouvreur acouvreur commented Dec 14, 2025

Description

This pull request adds the definition for the bluetooth common data types found https://www.bluetooth.com/wp-content/uploads/Files/Specification/HTML/Assigned_Numbers/out/en/Assigned_Numbers.pdf section 2.3.

The constant names are based on the bluetooth common data type "Name" column.

I've updated just a single example for now. If maintainers agree with that change, I can update more/all of the examples.

Related

Closes #18014

Testing

Simply run the updated examples.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Note

Introduce standardized BLE advertising data type macros in bt_common.h and update the BLE 5.0 throughput server example to use them.

  • Common/Headers:
    • Add BLE advertising data type macros in components/bt/common/include/bt_common.h (e.g., BT_AD_TYPE_FLAGS, service lists, local name, TX power, manufacturer data, etc.).
  • Examples:
    • Update examples/.../example_ble_server_throughput.c to #include "bt_common.h" and replace hardcoded AD type bytes in ext_adv_raw_data with the new macros.

Written by Cursor Bugbot for commit 912950a. This will update automatically on new commits. Configure here.

@github-actions
Copy link

github-actions bot commented Dec 14, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello acouvreur, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 912950a

@github-actions github-actions bot changed the title feat(bluetooth): add common data types feat(bluetooth): add common data types (IDFGH-16961) Dec 14, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 14, 2025
@CLAassistant
Copy link

CLAassistant commented Dec 14, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Opened Issue is new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Bluetooth Common Data Types definitions (IDFGH-16960)

3 participants