Skip to content

Conversation

@PetrESP
Copy link
Collaborator

@PetrESP PetrESP commented Dec 9, 2025

ESP-BSP Pull Request checklist

  • CI passing

Change description

Added a picture to the SD card example

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Test Results

28 tests   28 ✅  1m 32s ⏱️
 5 suites   0 💤
 5 files     0 ❌

Results for commit 348034c.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, could you remove the black corners from the image (make it transparent)?

@PetrESP PetrESP force-pushed the petr/feat/sd_card_example_picture branch from fd01e1d to 348034c Compare December 10, 2025 09:25
@PetrESP PetrESP requested a review from espzav December 10, 2025 09:30
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrESP Thank you! LGTM

@PetrESP PetrESP force-pushed the petr/feat/sd_card_example_picture branch from 348034c to d6a8c20 Compare December 10, 2025 10:04
@github-actions
Copy link

⚠️ Build failed for idf_ver=latest index=3

This failure was ignored (continue-on-error enabled).
See details: View build logs

@github-actions
Copy link

⚠️ Build failed for idf_ver=latest index=5

This failure was ignored (continue-on-error enabled).
See details: View build logs

@github-actions
Copy link

⚠️ Build failed for idf_ver=latest index=2

This failure was ignored (continue-on-error enabled).
See details: View build logs

@github-actions
Copy link

⚠️ Build failed for idf_ver=latest index=4

This failure was ignored (continue-on-error enabled).
See details: View build logs

@github-actions
Copy link

⚠️ Build failed for idf_ver=latest index=1

This failure was ignored (continue-on-error enabled).
See details: View build logs

@PetrESP PetrESP merged commit 7177d93 into master Dec 10, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants