Skip to content

Conversation

@PetrESP
Copy link
Collaborator

@PetrESP PetrESP commented Dec 9, 2025

ESP-BSP Pull Request checklist

  • Version of modified component bumped
  • CI passing

Change description

Drivers which support detection of multiple touch points have been extended.
Assertions in all touch drivers have been changed to ESP_RETURN_ON_FALSE
Function naming in touch drivers has been aligned

@PetrESP PetrESP requested a review from espzav December 9, 2025 13:17
@PetrESP PetrESP force-pushed the petr/feat/multi-touch_all_drivers branch from 44372b4 to 38a38e5 Compare December 9, 2025 13:19
@PetrESP PetrESP marked this pull request as ready for review December 9, 2025 13:19
@PetrESP PetrESP force-pushed the petr/feat/multi-touch_all_drivers branch from 38a38e5 to 129fd10 Compare December 9, 2025 13:26
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Test Results

28 tests   28 ✅  1m 31s ⏱️
 5 suites   0 💤
 5 files     0 ❌

Results for commit bb22e99.

♻️ This comment has been updated with latest results.

@PetrESP PetrESP force-pushed the petr/feat/multi-touch_all_drivers branch 3 times, most recently from b2602ec to 7a90e90 Compare December 9, 2025 16:12
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrESP thank you for these changes, but I think we can make another PR for functions renaming and assert changes.
The main features are hiddent here.
We can keep it for now.

I left some comments - I will try it on HW soon.

@PetrESP PetrESP force-pushed the petr/feat/multi-touch_all_drivers branch from 7a90e90 to 3574be7 Compare December 10, 2025 09:47
@PetrESP PetrESP force-pushed the petr/feat/multi-touch_all_drivers branch from ee55c50 to e7c98e5 Compare December 10, 2025 11:37
@PetrESP PetrESP force-pushed the petr/feat/multi-touch_all_drivers branch from e7c98e5 to bb22e99 Compare December 10, 2025 11:51
@github-actions
Copy link

⚠️ Build failed for idf_ver=latest index=5

This failure was ignored (continue-on-error enabled).
See details: View build logs

@github-actions
Copy link

⚠️ Build failed for idf_ver=latest index=3

This failure was ignored (continue-on-error enabled).
See details: View build logs

Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrESP Thank you! LGTM

@github-actions
Copy link

⚠️ Build failed for idf_ver=latest index=2

This failure was ignored (continue-on-error enabled).
See details: View build logs

@github-actions
Copy link

⚠️ Build failed for idf_ver=latest index=4

This failure was ignored (continue-on-error enabled).
See details: View build logs

@PetrESP PetrESP merged commit c927778 into master Dec 10, 2025
70 checks passed
@PetrESP PetrESP deleted the petr/feat/multi-touch_all_drivers branch December 10, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants