Fix PHP 8.2 Deprecation Warning #176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taufik-nurrohman
force-pushed
the
php-8.2-fix
branch
from
c934294 to
1f8185b
Compare
|
This gives me:
Also, why did you go from 0.8.0 to 0.8.2? There is already a 0.8.1 out. |
Author
|
I was editing from the
You must be using Parsedown version 1.7 and not the |
Author
|
BTW, the release orders are weird since the 1.8 versions.
|
BenjaminHoegh
approved these changes
Aug 13, 2023
|
Hey @aidantwoods @erusev could you look at this and see if you can approve it? would be great to have the parsedown family up and running again for php 8+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source: https://php.watch/versions/8.2/mbstring-qprint-base64-uuencode-html-entities-deprecated#html
Note: Could not use
htmlentities()here because it will encode the HTML markup which we don’t want. The solution comes from a comment in the official PHP website.