Bugfix: reset footnote count after each «text» call #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #97 : if you are parsing multiple text within a loop, the footnote count is never reset, so it keeps adding values.
For the tests, I added a new method for testing two calls to the sample text containing the footnotes and checking that after both calls the content is the same. I do not like it that much, because it leaves the code for the test a little bit dirty, as it uses the
ParsedownTesttests. Another solution would be to create a new test file or, even cleaner, to perform two calls inParsedownTest. I would change them if it is necessary.