Skip to content

Replace redundant error return with explicit nil #18693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Dogger21 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace redundant error return with explicit nil #18693

Dogger21 wants to merge 1 commit into from
+1 −1

Conversation

@Dogger21
Copy link

@Dogger21 Dogger21 commented Jan 16, 2026

Replaced return err with explicit return nil in writeFileWithFsyncAndFlags function

mh0lt
mh0lt requested changes Jan 17, 2026
View reviewed changes
Copy link
Contributor

@mh0lt mh0lt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove all of this with a simple

return f.Sync()

on line 141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mh0lt mh0lt mh0lt requested changes

@AskAlexSharov AskAlexSharov AskAlexSharov approved these changes

@Giulio2002 Giulio2002 Awaiting requested review from Giulio2002 Giulio2002 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Dogger21 @AskAlexSharov @mh0lt