-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix Failing Non List Validation Hive Tests #18666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bal-devnet-1
Are you sure you want to change the base?
Conversation
yperbasis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the unit tests failing?
Becuase this branch is running parallel execution by default and needs some fixes which are in main to make it work. |
Let's merge this to |
This conatains fixes for all outstanding non list validation fails when running:
Which should result in:
The know failing tests are:
I have also seen a one off fail of when testing but never been able to reproduce it, so am assuming it was a transient error:
The majority of the fixes are adjustments to the order of gas calculations to make sure that statless gas check haooen and fail early so that no storage acces occurs.
There are also some adjustments to when reads and writes occur and how they are reverted to ensure that these conform to the model required by the bals spec. These generally make state accesses more 'sticky' than the journalling process.