Skip to content

Conversation

@mh0lt
Copy link
Contributor

@mh0lt mh0lt commented Jan 14, 2026

This conatains fixes for all outstanding non list validation fails when running:

./hive --sim ethereum/eels/consume-engine --sim.limit=".*amsterdam/.*" --sim.parallelism=8 --docker.nocache=true --client erigon --sim.buildarg branch=hive --sim.buildarg [email protected] --sim.buildarg fixtures=https://github.com/ethereum/execution-spec-tests/releases/download/bal%40v2.0.0/fixtures_bal.tar.gz

Which should result in:

Jan 14 12:42:29.470 INF simulation ethereum/eels/consume-engine finished suites=1 tests=483 failed=6

The know failing tests are:

test_block_access_lists_invalid::py::test_bal_invalid_account_order
test_block_access_lists_invalid::py::test_bal_invalid_account
test_block_access_lists_invalid::py::test_bal_invalid_duplicate_account
test_block_access_lists_invalid::py::test_bal_invalid_tx_order
test_block_access_lists_invalid::py::test_bal_invalid_complex_corruption
test_block_access_lists_invalid::py::test_bal_invalid_missing_account

I have also seen a one off fail of when testing but never been able to reproduce it, so am assuming it was a transient error:

test_bal_7702_delegation_clear

The majority of the fixes are adjustments to the order of gas calculations to make sure that statless gas check haooen and fail early so that no storage acces occurs.

There are also some adjustments to when reads and writes occur and how they are reverted to ensure that these conform to the model required by the bals spec. These generally make state accesses more 'sticky' than the journalling process.

@mh0lt mh0lt requested a review from yperbasis as a code owner January 14, 2026 12:44
@yperbasis yperbasis added the Glamsterdam https://eips.ethereum.org/EIPS/eip-7773 label Jan 14, 2026
@yperbasis yperbasis requested a review from shohamc1 January 14, 2026 12:47
@mh0lt mh0lt changed the title Oog test fixes Fix Failing Non List Validation Hive Tests Jan 14, 2026
Copy link
Member

@yperbasis yperbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the unit tests failing?

@mh0lt
Copy link
Contributor Author

mh0lt commented Jan 16, 2026

Why are the unit tests failing?

Becuase this branch is running parallel execution by default and needs some fixes which are in main to make it work.

@yperbasis
Copy link
Member

Why are the unit tests failing?

Becuase this branch is running parallel execution by default and needs some fixes which are in main to make it work.

Let's merge this to main instead of bal-devnet-1 since devnet-1 is dead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Glamsterdam https://eips.ethereum.org/EIPS/eip-7773

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants