Skip to content

Fix undefined array key in Syllables by normalizing whitespace before explode #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix undefined array key in Syllables by normalizing whitespace before explode #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f16245
Initial plan
Copilot Feb 22, 2026
057a86d
Fix undefined array key in Syllables by normalizing whitespace before…
Copilot Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/DaveChild/TextStatistics/Syllables.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,7 @@ public static function totalSyllables($strText, $strEncoding = '')
public static function averageSyllablesPerWord($strText, $strEncoding = '')
{
$intSyllableCount = 0;
$strText = preg_replace('/\s+/', ' ', trim($strText));
$intWordCount = Text::wordCount($strText, $strEncoding);
$arrWords = explode(' ', $strText);
for ($i = 0; $i < $intWordCount; $i++) {
Expand All @@ -375,6 +376,7 @@ public static function averageSyllablesPerWord($strText, $strEncoding = '')
public static function wordsWithThreeSyllables($strText, $blnCountProperNouns = true, $strEncoding = '')
{
$intLongWordCount = 0;
$strText = preg_replace('/\s+/', ' ', trim($strText));
$intWordCount = Text::wordCount($strText, $strEncoding);
$arrWords = explode(' ', $strText);
for ($i = 0; $i < $intWordCount; $i++) {
Expand Down
22 changes: 22 additions & 0 deletions tests/TextStatisticsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,28 @@ public function testAverageSyllablesPerWord()
$this->assertEquals(1, $this->TextStatistics->averageSyllablesPerWord('and then there was one'));
$this->assertEquals(2, $this->TextStatistics->averageSyllablesPerWord('because special ducklings deserve rainbows'));
$this->assertEquals(1.5, $this->TextStatistics->averageSyllablesPerWord('and then there was one because special ducklings deserve rainbows'));
// Regression: non-space whitespace must not cause undefined array key warnings
$this->assertEquals(
$this->TextStatistics->averageSyllablesPerWord('and then'),
$this->TextStatistics->averageSyllablesPerWord("and\nthen")
);
$this->assertEquals(
$this->TextStatistics->averageSyllablesPerWord('and then'),
$this->TextStatistics->averageSyllablesPerWord("and\tthen")
);
$this->assertEquals(
$this->TextStatistics->averageSyllablesPerWord('and then'),
$this->TextStatistics->averageSyllablesPerWord("and\n\nthen")
);
}

public function testWordsWithThreeSyllablesWhitespace()
{
// Regression: non-space whitespace must produce the same result as spaces
$this->assertEquals(
DaveChild\TextStatistics\Syllables::wordsWithThreeSyllables('there is just one', true),
DaveChild\TextStatistics\Syllables::wordsWithThreeSyllables("there\nis\njust\none", true)
);
}

/* Test Words
Expand Down