Merged
Conversation
Degoot-AM
requested changes
Apr 4, 2025
Contributor
Degoot-AM
left a comment
Degoot-AM
left a comment
There was a problem hiding this comment.
Kudos to @alxsrobert , nice work. I have a few observations, please check out my comments and ping me again.
avallecam
reviewed
Apr 7, 2025
Member
avallecam
left a comment
avallecam
left a comment
There was a problem hiding this comment.
Thanks @alxsrobert for the contribution. The vignette is clear and concise. I tested the function with interventions and vaccinations and both worked as expected.
Among suggested edits, could you review the directionality of the epidemic peak from the gravity model?
avallecam
reviewed
Apr 7, 2025
Degoot-AM
reviewed
Apr 8, 2025
use callout style as in the main branch.
Degoot-AM
reviewed
Apr 8, 2025
Degoot-AM
reviewed
Apr 8, 2025
removing s form ntoes
Degoot-AM
approved these changes
Apr 8, 2025
Contributor
Degoot-AM
left a comment
Degoot-AM
left a comment
There was a problem hiding this comment.
Great job, @alxsrobert. I’ve updated the info callouts to follow the main branch styling
avallecam
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
combine_populationsfunction, which is used to combine age stratified populations into a population object. Currently, the combined population would have to be defined by the user. With this new function, the user can create two or morepopulationobjects, put them in a list, define a connectivity matrix between the populations and usecombine_populationsto create a new population object, containing all age groups from both populations. The PR contains a new vignette (combine_populations) that describes how thecombine_populationsfunction can be used.