Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #630
Summary
Fixes incorrect axis padding calculation when tick labels or axis labels contain
multiple lines (using
\n).Problem
When using custom formatters that output multi-line tick labels, the axis padding
calculation doesn't account for the actual height of the labels, causing:
Root cause: X-axis padding was calculated before X-axis ticks were generated,
so
axis.Ticker.MaxSize.ywas 0 or a default value. Additionally, axis labelheight was assumed to be single-line.
Solution
PadAndDatumAxesX()after ticks are generated (when actual tick label sizes areavailable), while preserving the title padding
CalcTextSize()for axis labels - Properly measure axis label heightinstead of assuming single-line (
T + P), allowing multi-line axis labels to workcorrectly
Before
Here's after the fix to take into account the tick label height and X axis label height