#4724 After clicking the "Clear Canvas" button multiple times, a user has to click the "Undo" button multiple times to return the structure #8894
+134
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How did you fix the issue?
In Macromolecules mode, clicking "Clear Canvas" on an empty canvas created undo history entries, requiring multiple undo operations to restore a structure. Micro mode had no such issue due to a guard in the action handler.
Root cause:
ClearToolunconditionally updated history regardless of canvas state. Macromolecules mode invokesClearTooldirectly, bypassing theisBlank()check present in the ketcher-react action handler.Fix: Added early return in
ClearToolconstructor when canvas is empty:This prevents history updates and object creation when clearing an already-empty canvas, making behavior consistent across both modes.
Check list
#1234 – issue nameOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.