Skip to content

Add overlay libc++ for arm64 when x-build#3779

Open
mathetake wants to merge 1 commit intomainfrom
cross
Open

Add overlay libc++ for arm64 when x-build#3779
mathetake wants to merge 1 commit intomainfrom
cross

Conversation

@mathetake
Copy link
Member

@mathetake mathetake commented Mar 7, 2026

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
@netlify
Copy link

netlify bot commented Mar 7, 2026

Deploy Preview for nifty-bassi-e26446 ready!

Name Link
🔨 Latest commit e99af38
🔍 Latest deploy log https://app.netlify.com/projects/nifty-bassi-e26446/deploys/69ac8d701c4f7800083b687f
😎 Deploy Preview https://deploy-preview-3779--nifty-bassi-e26446.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mathetake
Copy link
Member Author

still verifying

@mathetake mathetake marked this pull request as ready for review March 7, 2026 23:59
@mathetake
Copy link
Member Author

cool working

@mathetake mathetake requested a review from phlax March 7, 2026 23:59
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewing further and same comment as before - this is not the right place to put this - it needs to go in toolchains_llvm - sysroot does not carry the c++ libs, just glibc (and some related libs)

not only do i think that this doesnt belong here - it would swell the sysroot for all consumers for an edge case we never had till now

iiuc the underlying problem is of toolchains_llvm only providing libc++ for the arch that it provides a compiler for - so in your case it doesnt provide the arm libc++ because you are using the x86 compiler

really i think this needs to be resolved in toolchains_llvm - its not such an uncommon pattern and they have the machinery to do this cleanly - however, im also aware that that fix is non trivial

the compromise im thinking of is that we publish these libs for x-compile to a separate binary package - with a related repo setup in toolshed - similar to what we do for msan/tsan currently (sans the need to compile anything)

ill get a bot on the case with that now

@mathetake
Copy link
Member Author

the compromise im thinking of is that we publish these libs for x-compile to a separate binary package - with a related repo setup in toolshed - similar to what we do for msan/tsan currently (sans the need to compile anything)

sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants