I needed to make this change to install this gem #33
Conversation
Signed-off-by: Oliver Stigley <[email protected]>
ostigley
force-pushed
the
oliver/m1-mac-os-15.4-fix
branch
from
5e73b18 to
5d4a6aa
Compare
| @@ -1,5 +1,6 @@ | |||
| require 'mkmf' | |||
|
|
|||
| CONFIG['CXX'] = ENV['CXX'] || 'clang++' | |||
There was a problem hiding this comment.
I'm not sure what this will do to our ubuntu users (CMCG)
| @@ -1,5 +1,6 @@ | |||
| require 'mkmf' | |||
|
|
|||
| CONFIG['CXX'] = ENV['CXX'] || 'clang++' | |||
There was a problem hiding this comment.
This should be solved on the user's system. I'd rather we did a check for CXX and fail loudly up front if it's not present.
There was a problem hiding this comment.
We can do that with cxx.have_devel? it seems: https://github.com/ruby/ruby/blob/cbf9c088f8005a49b6aa3f475c70041357774c61/lib/mkmf.rb#L3022C9-L3022C20
|
|
||
| if have_macro("EXV_USE_CURL", "exiv2/exv_conf.h") | ||
| if dir_config("libcurl") == [nil, nil] | ||
| if dir_config("curl") == [nil, nil] |
There was a problem hiding this comment.
This only renames the flag --with-libcurl-dir to --with-curl-dir, but shouldn't affect compilation. Unless we have some really weird side effect here?
There was a problem hiding this comment.
Given I've resolved my issues and all fingers are pointing to ruby-build, I'm happy to clsoe this PR
I'm having trouble installing this gem on Market.
System details:
Mac OS 15.4
Ruby: 3.3.8
Making this change (with the help of chatgpt), and then running:
Installed the gem correctly.