Remove stale '--force' message from interactive clean preview#710
Draft
cursor[bot] wants to merge 2 commits intomainfrom
Draft
Remove stale '--force' message from interactive clean preview#710cursor[bot] wants to merge 2 commits intomainfrom
cursor[bot] wants to merge 2 commits intomainfrom
Conversation
The non-force mode now uses an interactive confirmation prompt instead of being a pure dry-run. The old 'Run with --force to delete these items.' message was contradictory when shown right before the confirmation dialog. Remove the stale message and update the test to verify it's no longer present.
4 tasks
peyton-alt
force-pushed
the
cli-output-consistency
branch
from
c8b64a4 to
54d30a4
Compare
3 tasks
peyton-alt
force-pushed
the
cli-output-consistency
branch
from
7286eb3 to
43aed19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the stale "Run with --force to delete these items." message that was shown in the non-force interactive flow right before the confirmation prompt.
Problem
When the default
entire cleanmode was changed from a pure dry-run to an interactive confirmation flow, the old guidance message wasn't updated. This resulted in contradictory output:The user doesn't need
--forcebecause the prompt already lets them confirm deletion.Fix
fmt.Fprintln(w, "Run with --force to delete these items.")fromrunCleanWithItemsTestRunClean_PreviewModeto verify the message is no longer present