-
Notifications
You must be signed in to change notification settings - Fork 336
Move Standard.Image out of distribution #14553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is now README.md in a namespace directory root.
Previously, was pointing to non-existing file, so the real `manifest.yaml` generated file was not cleaned.
|
First nightly release scheduled: https://github.com/enso-org/enso/actions/runs/20717064290
|
|
Choosing I realized this after the latest failure in the latest TL;DRFor the purpose of the demonstration, let's choose a library that has no native libraries. |
Image library is going to be uploaded to an external repository, therefore, we need all the native libraries included.
|
After fd8bb2283b65032aa587ed18b726145cb0947d73, the contents of This is needed because we don't yet have a way how to distinguish remote |
|
Another iteration of Nightly Release workflow at https://github.com/enso-org/enso/actions/runs/20748715350
|
engine/runtime-language-epb/src/main/java/org/enso/interpreter/epb/HostClassLoader.java
Show resolved
Hide resolved
|
Suggestions work locally on ec3f261. Tested with:
|
engine/runtime-language-epb/src/main/java/org/enso/interpreter/epb/HostClassLoader.java
Outdated
Show resolved
Hide resolved
engine/runtime-language-epb/src/main/java/org/enso/interpreter/epb/HostClassLoader.java
Show resolved
Hide resolved
| } catch (Throwable e) { | ||
| logger.log(Logger.Level.TRACE, "Failure while loading a class: " + e.getMessage(), e); | ||
| throw e; | ||
| if (isAttemptToLoadBytecodeInNI(e)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What class(es) required the 355bd3d check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
org.enso.base.Text_Utils. See the failure message in #14553 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's very weird. I believe Text_Utils should be compiled into NI. Maybe we somehow get into findClass without trying to HostClassLoader.loadClass or HostClassLoader.getParent.loadClass first... Very strange.
isAOT can be checked via `TruffleOptions`.
97f2eb1 to
d08e428
Compare
|
These failing tests: ❌ should provide an image file should be moved to Image tests out of |
|
What about:
|
Good question. |
# Conflicts: # distribution/lib/Standard/Examples/0.0.0-dev/docs/api/Main.md

Closes #14469
Pull Request Description
Move
Standard.Imageout of the distribution, as an external library that will be hosted on GH as an artifact.Important Notes
Standard.Imagebuild was modified such that it contains all the native libraries for all platforms. See Move Standard.Image out of distribution #14553 (comment).main.tgzsource archive is created - e11deb3--enable-urls-protocols=jar,httpshas been added. This caused some issues with class loading that has been fixed by a hack. See Move Standard.Image out of distribution #14553 (comment)Standard.Imageare deleted from the release artifacts.std_image_repo.zipis the only asset containingStandard.Imagelibrary.Standard.ImagefromStandard.Examplesin ec3f261.Remaining problems
Standard.Imagedoes not work after the library has been downloaded. See Move Standard.Image out of distribution #14553 (comment)Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.