Use the entityType to determine the characteristicType for eg/lpc and eg/lpp #191
+18
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were previously unset and defaulted to nil which caused all tests checking the Production/ConsumptionNominalMax to be incorrect.
…eristicType. Using the entityType should be more correct than relying on the deviceType.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the LPC/LPP code was using the deviceType to determine whether we should check the PowerNominalMax or ContractualNominalMax data points. It should be more correct to use the EntityType instead since the specification mentions "CEM" explicitly.
This PR also sets the DeviceType in the LPC/LPP Test Suites as this defaulted to nil (and caused issue with the old variant that was checking the DeviceType).