Generate spec file when creating srpm

[bkmgit]

No description provided.

[bkmgit]

Closes #100

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo dnf install -y 'dnf*-command(copr)'
• dnf copr enable packit/enactic-openarm_can-100
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[kou]

Could you do this by rake -C packages yum:spec (packages/Rakefile not the top-level Rakefile)? Packages related code exist in packages/.

Could you use packages/yum/openarm-can.spec.in not .../fedora/...? We can reuse existing code by using packages/yum/openarm-can.spec.in.

diff --git a/packages/Rakefile b/packages/Rakefile
index 6091959..e921775 100644
--- a/packages/Rakefile
+++ b/packages/Rakefile
@@ -89,12 +89,36 @@ class OpenArmCANPackageTask < PackageTask
     false
   end
 
-  def update_spec
-    update_content("fedora/openarm-can.spec") do |content|
-      content.gsub!(/^(Version:\s+)[\d.]+$/) do
-        "#{$1}#{@version}"
+  def yum_spec
+    "#{yum_dir}/#{@rpm_package}.spec"
+  end
+
+  def define_yum_task
+    super
+
+    file yum_spec => yum_spec_in_path do
+      spec_in_data = File.read(yum_spec_in_path, encoding: "UTF-8")
+      spec_data = substitute_content(spec_in_data) do |key, matched|
+        yum_expand_variable(key) || matched
+      end
+      File.open(spec, "w") do |spec_file|
+        spec_file.print(spec_data)
       end
     end
+
+    namespace :yum do
+      desc "Update #{yum_spec}"
+      task spec: yum_spec
+    end
+  end
+
+  def yum_expand_variable(key)
+    case key
+    when "EXECUTABLES"
+      # ...
+    else
+      super
+    end
   end
 
   def define_archive_task

FYI: @VERSION@ is expanded by default: https://github.com/apache/arrow/blob/3dc982183db45ced57ef1565e022dcb647a00745/dev/tasks/linux-packages/package-task.rb#L444-L455

[bkmgit]

Would it be possible to make https://github.com/apache/arrow/blob/main/dev/tasks/linux-packages/package-task.rb part of a gem? This would allow easy reuse in other projects.

Requiring Arrow and Groonga repositories at https://github.com/enactic/openarm_can/blob/main/packages/Rakefile#L17-L29 complicates the workflow. For the moment have placed the Rakefile in packages/yum/Rakefile to avoid these extra dependencies. If the logic they encode could be in a separate Gem or repository for use by multiple projects, it would be easier to incorporate.

[bkmgit]

Happy to help with refactoring.

[bkmgit]

/packit build