-
Notifications
You must be signed in to change notification settings - Fork 790
[bazel] Remove dependency on system python #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8954578
c0dc092
dae7397
147e21f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,4 @@ | |
|
|
||
| source $(dirname $0)/env.sh | ||
|
|
||
| exec python3 $EMSCRIPTEN/emar.py "$@" | ||
| exec $EMSDK_PYTHON $EMSCRIPTEN/emar.py "$@" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if could now maybe remove these custom launcher scripts and just use the standard emcc launcher shell script (as a followup, no in this PR) I guess it depends what else in env.sh is needed?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I actually tried that in one of my unsuccessful iterations. I replaced all those scripts with pure Python, presented them to Bazel via The first problem was that binaries were resolved in the "target context (WASM)" instead of the "exec" context, which then tried to run the "WASM version of Python", which doesn't exist. I circumvented that by creating a transitioned binary in My first working solution required a patch to In the future, I'll probably revisit this approach that uses pure Python without any shell wrappers, but I still need to get better at Bazel before that (I'm still learning it). |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,4 @@ | |
|
|
||
| source $(dirname $0)/env.sh | ||
|
|
||
| exec python3 $EMSCRIPTEN/emcc.py "$@" | ||
| exec $EMSDK_PYTHON $EMSCRIPTEN/emcc.py "$@" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbc100 ,
This is also closing 1642 issue? Shall Closes #xxx be added to the description and maybe several others ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please update the PR description (we use
Fixes: #xxx)