Fix pending signals to be TLS#26666
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 13, 2026
Merged
Conversation
sbc100
force-pushed
the
sig_pending
branch
3 times, most recently
from
0df0b51 to
6643dc8
Compare
Also, add some testing for this. I also ran this test under native clang / glibc on my desktop and got the expected results.
Member
|
Is this in reference to a particular bug? |
Collaborator
Author
No, I just noticed this will browsing the source. |
Collaborator
Author
|
I was looking into improving the async signal delivery and I noticed that we were not even storing pending signals per thread! |
sbc100
requested review from
dschuff and
tlively
and removed request for
dschuff
tlively
approved these changes
Apr 13, 2026
Member
|
Oops, didn't see that auto-merge was enabled. |
Collaborator
Author
|
Sorry, will land typo fixes as followup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, add some testing for this. I also ran this test under native clang / glibc on my desktop and got the expected results.