Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: keyUp events were not being sent (to InputCallback) on mac while the command key was pressed.
I tried messing with acceptsFirstResponder, adding different views, etc. but I couldn't get macOS to send these events.
But addLocalMonitorForEventsMatchingMask:NSEventMaskKeyUp seems to work consistently. This is an application-wide hook, though, so the code has to filter the events to ensure each window only handles those meant for it. It's slightly inefficient in that each window registers its own monitor, but I couldn't see an obvious way to avoid that.
Caution: I know next to nothing about macOS programming. Multiple LLMs helped me figure this out.