Skip to content

feat: set media player preference as enabled by default#3271

Draft
ayoayco wants to merge 3 commits intoelk-zone:mainfrom
ayoayco:feat/promote-media-player-as-not-experimental
Draft

feat: set media player preference as enabled by default#3271
ayoayco wants to merge 3 commits intoelk-zone:mainfrom
ayoayco:feat/promote-media-player-as-not-experimental

Conversation

@ayoayco
Copy link
Member

@ayoayco ayoayco commented Apr 25, 2025

Proposal to promote the media player as not experimental 😄

We decided to put this feature as experimental to gather feedback and bug reports. I looked through the issues to see if there are complaints regarding the media player, but there seems to be none! 🎉

This PR will

  • set the preference to show embedded media player as true by default
  • promote embedded media player as not experimental

- set preference as true
- promote embedded media player as not experimental
@ayoayco ayoayco requested a review from shuuji3 April 25, 2025 12:28
@netlify
Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit c94af09
🔍 Latest deploy log https://app.netlify.com/projects/elk-zone/deploys/697cbc56b85cac000879485b
😎 Deploy Preview https://deploy-preview-3271--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit c680e17
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/680b80020089a400081ad114

@ayoayco ayoayco requested a review from userquin April 25, 2025 16:17
@userquin
Copy link
Member

userquin commented Apr 25, 2025

Restore old experimental value and delete it once the new preference saved (the problem, we don't know if the user has disabled the experimental feature so we need to restore the original value if experimental still there, otherwise we don't need to change the new feature since it is enabled by default)

/cc @patak-dev @shuuji3

@ayoayco
Copy link
Member Author

ayoayco commented Apr 26, 2025

I will check, thanks!!

@netlify
Copy link

netlify bot commented Nov 6, 2025

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit c94af09
🔍 Latest deploy log https://app.netlify.com/projects/elk-docs/deploys/697cbc561f2b190007c0b402

@ayoayco ayoayco marked this pull request as draft November 7, 2025 11:30
@shuuji3
Copy link
Member

shuuji3 commented Jan 30, 2026

Since setting this as default means we think it's stable and recommend using it, I think we could let this one time change and merge it as is? (For me, I've been using this nice player for a while and haven't seen any issues.)

Some people might have tried it and turned it off, but I think there are many more people who haven't even tried it yet. Keeping the existing value will let those people miss this useful feature after that.

@shuuji3
Copy link
Member

shuuji3 commented Jan 30, 2026

The current default value is false (I think it was automatically stored after update) so we cannot distinguish if the value false means that it was turned off manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments