feat: add severed_relationships notification type#3134
feat: add severed_relationships notification type#3134dibenzepin wants to merge 5 commits intoelk-zone:mainfrom
severed_relationships notification type#3134Conversation
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Yes, using upstream localization is a smart idea.👍🏻 It's also nice to have Those expansions can be included in this PR or separated if you'd like. |
|
Probably not applicable in this case. Those are usually for short-string localization. But I'll review the guidelines later. Also probably we'll need another type than |
| </p> | ||
|
|
||
| <NuxtLink :to="`https://${currentServer}/severed_relationships`" target="_blank"> | ||
| Learn more |
There was a problem hiding this comment.
We can mark these words as translatable.
severed_relationships notification typesevered_relationships notification type
|
OK, I just fixed type check errors. Those are a bit complicated. One type of error requires yo update type definition in the upstream library, masto.js. The other one was due to a failure of type inference in Vue template. Anyway, you don't have to worry about them in this PR. |
74ce35e to
5aa2b31
Compare
|
I upstreamed the missing prop in |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/form-data@4.0.0, npm/js-yaml@4.1.0 |
kind of a follow-up to #3077 and #3084, which added the console logging for unsupported noti types, but not the notification for
severed_relationships.it looks like:

compared to my instance's:

copied the language from upstream, I can probably just use their localisations too, right?
I'll probably expand the PR to add in
moderation_warningif I can get a pic of how it should look like (or barring that, just copying upstream's impl)(and maybe refactor
annual_reportto use localisations too?)(also a bit unsure if i'm following the pluralisation guidelines, but hey, that's why it's a draft PR)