Fix MatchError crash when TURN socket closes during allocation refresh #91
+24
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle {:error, :closed} when transport_module.send fails during
TURN allocation refresh. Previously caused MatchError crashes that
terminated WebRTC streams.
Changes:
- Wrap transport_module.send calls in case statements
- Gracefully close transactions/candidates on socket errors
- Add debug logging for troubleshooting
Fixes crashes at lines 947 and 976 when TURN sockets close unexpectedly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crash:
When TURN sockets close unexpectedly during allocation refresh,
transport_module.send/3returns{:error, :closed}, causing the above MatchError that terminates WebRTC streams.This PR wraps the send calls in case statements to handle errors gracefully by closing the transaction/candidate and cleaning up state.