Add the ability to have safe params#106
Open
cheerfulstoic wants to merge 1 commit intoelixir-soap:masterfrom
Open
Add the ability to have safe params#106cheerfulstoic wants to merge 1 commit intoelixir-soap:masterfrom
cheerfulstoic wants to merge 1 commit intoelixir-soap:masterfrom
Conversation
This will pass a {:safe, _} tuple down into XmlBuilder where we can avoid escaping strings that don't need to be escaped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue I'm trying to fix: we're sending Base64-encoded files in some SOAP requests and seeing overhead of ~200ms per request that we'd like to avoid. After some investigation I found that it's possible to skip the escaping of values in
XmlBuilder.This adds the ability for users of
soapto specify a{:__safe, _}value for a param. This will pass a {:safe, _} tuple down into XmlBuilder where we can avoid escaping strings that don't need to be escaped. I chose{:__safe, _}instead of{:safe, _}forsoapbecause somebody might want to have a<safe>tag in their XML. Happy to talk that through.