Pass nodelay as a TCP option instead of a TLS option#419
Merged
sleipnir merged 2 commits intoelixir-grpc:masterfrom May 9, 2025
Merged
Pass nodelay as a TCP option instead of a TLS option#419sleipnir merged 2 commits intoelixir-grpc:masterfrom
sleipnir merged 2 commits intoelixir-grpc:masterfrom
Conversation
Gun passes tcp options in `gen_tcp:connect`, and tls options in `ssh:connect/2`. `ssh:connect/2` ignores the `nodelay` option.
polvalente
approved these changes
May 9, 2025
sleipnir
approved these changes
May 9, 2025
Contributor
Author
|
Folks, I'd love if this could get released. I see there's no more changes after v0.10, so perhaps it could make a patch release :) |
Collaborator
I think we can do one of two things:
Wdyt guys? |
Contributor
Author
|
I'm biased for the 0.10.1 release. I think this can benefit people now, and I assume 1.0 will probably take some time between RCs and ensuring the new APIs work, so (if I have a right to vote) I'd vote for a quick 0.10.1 :) |
Contributor
|
+1 for 0.10.1! |
Collaborator
|
Ok. I will prepare the version! |
Collaborator
|
Release published https://hexdocs.pm/grpc/0.10.1/readme.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gun passes tcp options in
gen_tcp:connect, and tls options inssh:connect/2.ssh:connect/2ignores thenodelayoption.This patch ensures that when using
ssl, the client still passnodelayintcp_options, which makes sure it's used.