refactor: use Keyword.validate! and bump to v0.10 and elixir 1.15#416
Merged
refactor: use Keyword.validate! and bump to v0.10 and elixir 1.15#416
Conversation
polvalente
force-pushed
the
pv-refactor/use-keyword-validate
branch
from
aa25ce8 to
d98fe15
Compare
polvalente
commented
Apr 27, 2025
sleipnir
approved these changes
Apr 27, 2025
Collaborator
sleipnir
left a comment
sleipnir
left a comment
There was a problem hiding this comment.
Just remove the comment and let's go
sleipnir
approved these changes
Apr 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Keyword.validate! calls to places where we have a closed set of keys in keyword lists